netdev - Re: [WEXT 8/12]: Pull top-level ioctl dispatch logic into helper function.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20080603.073453.69571531.davem@davemloft.net>
Date:	Tue, 03 Jun 2008 07:34:53 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	mokuno@...sony.co.jp
Cc:	linux-wireless@...r.kernel.org, netdev@...r.kernel.org
Subject: Re: [WEXT 8/12]: Pull top-level ioctl dispatch logic into helper
 function.

From: Masakazu Mokuno <mokuno@...sony.co.jp>
Date: Mon, 21 Jan 2008 20:16:19 +0900

I am working on these patches again, thank you for your
extreme patience...

> > +int wext_handle_ioctl(struct net *net, struct ifreq *ifr, unsigned int cmd,
> > +		      void __user *arg)
> > +{
> > +	int ret = wext_ioctl_dispatch(net, ifr, cmd,
> > +				      ioctl_standard_call,
> > +				      ioctl_private_call);
> > +
> > +	if (ret > 0 &&
> 
> As the return value 0 is legal, should we allow copybacking in the case
> of 'ret == 0'?
> 
> Same issue exists in compat_wext_handle_ioctl() of the #9 patch.

You are right, I wonder why I made this strange test.  It should
definitely be "ret >= 0".  I'll make that fix.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html