netdev - Re: [PATCH] tcp: Increment OUTRSTS in tcp_send_active

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20080604.152014.185732768.davem@davemloft.net>
Date:	Wed, 04 Jun 2008 15:20:14 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	sri@...ibm.com
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH] tcp: Increment OUTRSTS in tcp_send_active_reset()

From: Sridhar Samudrala <sri@...ibm.com>
Date: Fri, 30 May 2008 10:02:27 -0700

> TCP "resets sent" counter is not incremented when a TCP Reset is 
> sent via tcp_send_active_reset().
> 
> Signed-off-by: Sridhar Samudrala <sri@...ibm.com>
> 
> diff --git a/net/ipv4/tcp_output.c b/net/ipv4/tcp_output.c
> index e399bde..23c22d4 100644
> --- a/net/ipv4/tcp_output.c
> +++ b/net/ipv4/tcp_output.c
> @@ -2131,6 +2131,8 @@ void tcp_send_active_reset(struct sock *sk, gfp_t priority)
>  	TCP_SKB_CB(skb)->when = tcp_time_stamp;
>  	if (tcp_transmit_skb(sk, skb, 0, priority))
>  		NET_INC_STATS(LINUX_MIB_TCPABORTFAILED);
> + 
> +	TCP_INC_STATS(TCP_MIB_OUTRSTS);
>  }
>  
>  /* WARNING: This routine must only be called when we have already sent

Patch applied.

That line before the new TCP_INC_STATS() adds trailing whitespace.
I fixed it up this time, but please have all of these details sorted
out before posting patches in the future, thank you.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html