netdev - Re: [PATCH 2/2 try#2] L2TP: Fix possible oops if transmitting or receiving when tunnel goes down

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 04 Jun 2008 15:55:03 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	jchapman@...alix.com
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH 2/2 try#2] L2TP: Fix possible oops if transmitting or
 receiving when tunnel goes down

From: James Chapman <jchapman@...alix.com>
Date: Wed, 4 Jun 2008 23:52:16 +0100

> [L2TP] Fix possible oops if transmitting or receiving when tunnel goes down
> 
> Some problems have been experienced in the field which cause an oops
> in the pppol2tp driver if L2TP tunnels fail while passing data.
> 
> The pppol2tp driver uses private data that is referenced via the
> sk->sk_user_data of its UDP and PPPoL2TP sockets. This patch makes
> sure that the driver uses sock_hold() when it holds a reference to the
> sk pointer. This affects its sendmsg(), recvmsg(), getname(),
> [gs]etsockopt() and ioctl() handlers.
> 
> Tested by ISP where problem was seen. System has been up 10 days with
> no oops since running this patch. Without the patch, an oops would
> occur every 1-2 days.
> 
> Signed-off-by: James Chapman <jchapman@...alix.com> 

Applied, thanks James.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html