[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-Id: <20080604.112015.241905253.davem@davemloft.net>
Date: Wed, 04 Jun 2008 11:20:15 -0700 (PDT)
From: David Miller <davem@...emloft.net>
To: ilpo.jarvinen@...sinki.fi
Cc: brian.vowell@...il.com, akpm@...ux-foundation.org,
netdev@...r.kernel.org, bugme-daemon@...zilla.kernel.org
Subject: Re: [Bugme-new] [Bug 10767] New: Seg Fault Instead of Swapping
From: "Ilpo_Järvinen" <ilpo.jarvinen@...sinki.fi>
Date: Wed, 4 Jun 2008 10:12:04 +0300 (EEST)
> On Tue, 3 Jun 2008, David Miller wrote:
>
> > From: "Ilpo_Järvinen" <ilpo.jarvinen@...sinki.fi>
> > Date: Mon, 26 May 2008 14:24:33 +0300 (EEST)
> >
> > Ilpo, do you want me to apply this to net-2.6?
>
> Yes thanks, it is necessary to keep the state consistent (it also explains
> some .22/23 time left_out warn_ons too which were mysterious back then).
> Also -stable (I guess it would be necessary to almost any older stable
> too though some older ones might want to sync left_out on that same place
> too).
>
> It was nice that this path was also triggered while running the TCP
> debug patch (I haven't gotten a one in here), otherwise we would never
> have known though I started to suspect that such path existed once I
> tried to analyze those left_out problems (before it got dropped
> altogether), but I just couldn't find the problem because it lies on
> such "error path" which was too easy to overlook.
Ok I've add the patch to net-2.6, thanks!
> I also finally have found the cause to the !sacked_out && fackets_out
> trap :-). ...I'll post the fix to that later today to relevant parties.
I'll have a look at this too :-)
Thanks for all of your incredible work on TCP bug fixing!
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists