netdev - Re: [2.6 patch] include/linux/ssb/ssb_driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LFD.1.10.0806051432220.6496@localhost.localdomain>
Date:	Thu, 5 Jun 2008 14:34:35 -0400 (EDT)
From:	"Robert P. J. Day" <rpjday@...shcourse.ca>
To:	Adrian Bunk <bunk@...nel.org>
cc:	Michael Buesch <mb@...sch.de>,
	"John W. Linville" <linville@...driver.com>,
	netdev@...r.kernel.org,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Ralf Baechle <ralf@...ux-mips.org>
Subject: Re: [2.6 patch] include/linux/ssb/ssb_driver_gige.h typo fix

On Thu, 5 Jun 2008, Adrian Bunk wrote:

> This patch fixes a typo in the name of a config variable.
>
> Reported-by: Robert P. J. Day <rpjday@...shcourse.ca>
> Signed-off-by: Adrian Bunk <bunk@...nel.org>
>
> ---
> 2aab8eeb46b30baf987c344e1b144caec365373a diff --git a/include/linux/ssb/ssb_driver_gige.h b/include/linux/ssb/ssb_driver_gige.h
> index 01fbdf5..942e387 100644
> --- a/include/linux/ssb/ssb_driver_gige.h
> +++ b/include/linux/ssb/ssb_driver_gige.h
> @@ -100,7 +100,7 @@ extern char * nvram_get(const char *name);
>  /* Get the device MAC address */
>  static inline void ssb_gige_get_macaddr(struct pci_dev *pdev, u8 *macaddr)
>  {
> -#ifdef CONFIG_BCM947XX
> +#ifdef CONFIG_BCM47XX
>  	char *res = nvram_get("et0macaddr");
>  	if (res)
>  		memcpy(macaddr, res, 6);
>

just FYI, there are more (admittedly aesthetic) references to
BCM947XX in the MIPS directory:

$ grep -r "BCM947XX" *
include/linux/ssb/ssb_driver_gige.h:#ifdef CONFIG_BCM947XX
include/asm-mips/mach-bcm47xx/war.h:#ifndef __ASM_MIPS_MACH_BCM947XX_WAR_H
include/asm-mips/mach-bcm47xx/war.h:#define __ASM_MIPS_MACH_BCM947XX_WAR_H
include/asm-mips/mach-bcm47xx/war.h:#endif /* __ASM_MIPS_MACH_BCM947XX_WAR_H */
$

  whether you want to do anything about those is up to you.

rday
--

========================================================================
Robert P. J. Day
Linux Consulting, Training and Annoying Kernel Pedantry:
    Have classroom, will lecture.

http://crashcourse.ca                          Waterloo, Ontario, CANADA
========================================================================
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html