netdev - Re: [ofa-general] Re: [PATCH v3 08/13] QLogic VNIC: sysfs interface implementation for the driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <48486EB9.4010706@trash.net>
Date:	Fri, 06 Jun 2008 00:54:49 +0200
From:	Patrick McHardy <kaber@...sh.net>
To:	Roland Dreier <rdreier@...co.com>
CC:	Stephen Hemminger <shemminger@...tta.com>,
	Amar Mudrankit <amar.mudrankit@...gic.com>,
	Dave Dillow <dillowda@...l.gov>, Greg KH <greg@...ah.com>,
	general@...ts.openfabrics.org, netdev@...r.kernel.org,
	poornima.kamath@...gic.com
Subject: Re: [ofa-general] Re: [PATCH v3 08/13] QLogic VNIC: sysfs interface
 implementation for the driver

Roland Dreier wrote:
>  > > There is nothing stopping adding a well designed alternate interface.
>  > > Either netlink or ioctl's are okay. As long as it is 32/64 bit clean.
>
>  > From a quick look it seems it should use rtnl_link instead
>  > of adding yet another private sysfs interface.
>
> This seems crazy -- why do we want to push things towards the complexity
> of rtnl_link instead of a simple text-based interface that can be
> trivial used with 'echo' from the shell?

Its not complicated at all. Ability to use "echo" seems like a
pretty poor argument to me.

>   What advantages does that give?

- atomic configuration changes
- atomic configuration dumps
- configuration change notifications
- same interface as for all other network-related configurations
- easily extensible
- not yet another private driver interface
- not text based, which makes it a lot more convenient for using in programs



--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html