netdev - Re: [PATCH] ipv6 addrconf: Ignore requests to set NODAD flag when changing addresses

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080605090447.GL20815@postel.suug.ch>
Date:	Thu, 5 Jun 2008 11:04:47 +0200
From:	Thomas Graf <tgraf@...g.ch>
To:	"YOSHIFUJI Hideaki / ?$B5HF#1QL@" <yoshfuji@...ux-ipv6.org>
Cc:	netdev@...r.kernel.org, usagi-core@...linux-ipv6.org,
	nakam@...agoma.org, takamiya@...ntts.co.jp
Subject: Re: [PATCH] ipv6 addrconf: Ignore requests to set NODAD flag when changing addresses

* YOSHIFUJI Hideaki / ?$B5HF#1QL@ <yoshfuji@...ux-ipv6.org> 2008-06-05 11:53
> And well, it does not take effect so far, but 
> DAD after link failure logic is planned in long term.
> So current code is okay to me.

Alright, that makes sense if that code ever is written.

I'm not sure I understand your new patch though, why do you want to
disable setting the nodad flag for new addresses nowW?

> 
> Signed-off-by: YOSHIFUJI Hideaki <yoshfuji@...ux-ipv6.org>
> 
> diff --git a/net/ipv6/addrconf.c b/net/ipv6/addrconf.c
> index 3a83557..05dcfd8 100644
> --- a/net/ipv6/addrconf.c
> +++ b/net/ipv6/addrconf.c
> @@ -3191,7 +3191,7 @@ static int inet6_addr_modify(struct inet6_ifaddr *ifp, u8 ifa_flags,
>  		prefered_lft = 0x7FFFFFFF/HZ;
>  
>  	spin_lock_bh(&ifp->lock);
> -	ifp->flags = (ifp->flags & ~(IFA_F_DEPRECATED | IFA_F_PERMANENT | IFA_F_NODAD | IFA_F_HOMEADDRESS)) | ifa_flags;
> +	ifp->flags = (ifp->flags & ~(IFA_F_DEPRECATED | IFA_F_PERMANENT | IFA_F_HOMEADDRESS)) | ifa_flags;
>  	ifp->tstamp = jiffies;
>  	ifp->valid_lft = valid_lft;
>  	ifp->prefered_lft = prefered_lft;
> @@ -3245,7 +3245,7 @@ inet6_rtm_newaddr(struct sk_buff *skb, struct nlmsghdr *nlh, void *arg)
>  		return -ENODEV;
>  
>  	/* We ignore other flags so far. */
> -	ifa_flags = ifm->ifa_flags & (IFA_F_NODAD | IFA_F_HOMEADDRESS);
> +	ifa_flags = ifm->ifa_flags & IFA_F_HOMEADDRESS;
>  
>  	ifa = ipv6_get_ifaddr(net, pfx, dev, 1);
>  	if (ifa == NULL) {
> 
> --yoshfuji
> 
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html