netdev - Re: [PATCH 14/39] mv643xx_eth: remove port serial status register bit defines

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080605114144.GN1059@farnsworth.org>
Date:	Thu, 5 Jun 2008 04:41:44 -0700
From:	Dale Farnsworth <dale@...nsworth.org>
To:	Lennert Buytenhek <buytenh@...tstofly.org>
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH 14/39] mv643xx_eth: remove port serial status register
	bit defines

On Tue, Jun 03, 2008 at 01:02:29PM +0200, Lennert Buytenhek wrote:
> All except one of the port serial status register bit defines are
> unused -- kill the unused ones.
> 
> Signed-off-by: Lennert Buytenhek <buytenh@...vell.com>
> ---
>  drivers/net/mv643xx_eth.c |   15 ++-------------
>  1 files changed, 2 insertions(+), 13 deletions(-)
> 
> diff --git a/drivers/net/mv643xx_eth.c b/drivers/net/mv643xx_eth.c
> index 075ee2a..34bfdf6 100644
> --- a/drivers/net/mv643xx_eth.c
> +++ b/drivers/net/mv643xx_eth.c
> @@ -94,6 +94,7 @@ static char mv643xx_driver_version[] = "1.0";
>  #define SDMA_CONFIG(p)			(0x041c + ((p) << 10))
>  #define PORT_SERIAL_CONTROL(p)		(0x043c + ((p) << 10))
>  #define PORT_STATUS(p)			(0x0444 + ((p) << 10))
> +#define  TX_FIFO_EMPTY			0x00000400

Oops, an extra space sneaked in.

>  #define TXQ_COMMAND(p)			(0x0448 + ((p) << 10))
>  #define TX_BW_MTU(p)			(0x0458 + ((p) << 10))
>  #define INT_CAUSE(p)			(0x0460 + ((p) << 10))

[snip]

Looks good otherwise.

-Dale
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html