netdev - Re: [PATCH 24/39] mv643xx_eth: kill private unused instance of struct net_device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080605120814.GL3807@farnsworth.org>
Date:	Thu, 5 Jun 2008 05:08:14 -0700
From:	Dale Farnsworth <dale@...nsworth.org>
To:	Lennert Buytenhek <buytenh@...tstofly.org>
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH 24/39] mv643xx_eth: kill private unused instance of
	struct net_device_stats

On Tue, Jun 03, 2008 at 01:02:39PM +0200, Lennert Buytenhek wrote:
> The per-port mv643xx_eth_private struct had a private instance
> of struct net_device_stats that was never ever written to, only
> read (via the ethtool statistics interface).  This patch gets
> rid of the private instance, and tweaks the ethtool statistics
> code in mv643xx_eth to use the statistics in struct net_device
> instead.
> 
> Signed-off-by: Lennert Buytenhek <buytenh@...vell.com>
> ---
>  drivers/net/mv643xx_eth.c |  120 +++++++++++++++++++++++++--------------------
>  1 files changed, 66 insertions(+), 54 deletions(-)

Acked-by: Dale Farnsworth <dale@...nsworth.org>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html