netdev - Re: [PATCH 04/39] mv643xx_eth: get rid of individual port config register bit defines

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080606105242.GA5499@farnsworth.org>
Date:	Fri, 6 Jun 2008 03:52:42 -0700
From:	Dale Farnsworth <dale@...nsworth.org>
To:	Lennert Buytenhek <buytenh@...tstofly.org>
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH 04/39] mv643xx_eth: get rid of individual port config
	register bit defines

On Fri, Jun 06, 2008 at 08:58:39AM +0200, Lennert Buytenhek wrote:
> On Thu, Jun 05, 2008 at 04:07:34AM -0700, Dale Farnsworth wrote:
> > >  	config_reg = rdl(mp, PORT_CONFIG(mp->port_num));
> > >  	if (dev->flags & IFF_PROMISC)
> > > -		config_reg |= (u32) UNICAST_PROMISCUOUS_MODE;
> > > +		config_reg |= 0x00000001;
> > 
> > Except for the stupid cast, I think the meaning was clearer with the
> > define.
> 
> Right, I got a bit carried away. :-)  How about this instead:

Looks good.

-Dale
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html