netdev - Re: [PATCH] phylib: Don't allow core of phylib to build as a module

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 6 Jun 2008 09:19:50 -0600
From:	"Grant Likely" <grant.likely@...retlab.ca>
To:	"Scott Wood" <scottwood@...escale.com>
Cc:	"Kumar Gala" <galak@...nel.crashing.org>, netdev@...r.kernel.org,
	"Jeff Garzik" <jeff@...zik.org>, linuxppc-dev@...abs.org
Subject: Re: [PATCH] phylib: Don't allow core of phylib to build as a module

On Mon, Jun 2, 2008 at 5:20 PM, Scott Wood <scottwood@...escale.com> wrote:
> Kumar Gala wrote:
>> I think we'd be better off with a small stub that is always built into the
>> kernel for phy_read/phy_write, etc or the function pointer indirection
>> mechanism.
>
> And then instead of build failures, you'd get a silent runtime failure to
> apply the workaround if phylib is built as a module.

Indeed; I vote for the build failure over the silent runtime failure.
If a platform needs it and does not select it, then the platform is
broken and it is a bug.

Cheers,
g.

-- 
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html