lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Fri, 6 Jun 2008 12:19:02 -0500
From:	Andy Fleming <afleming@...escale.com>
To:	Andy Fleming <afleming@...escale.com>
Cc:	steve.glendinning@...c.com, netdev@...r.kernel.org
Subject: Re: phylib interrupt question


On Jun 6, 2008, at 12:11, Andy Fleming wrote:

>
> On Jun 6, 2008, at 11:07, steve.glendinning@...c.com wrote:
>
>> Hi everybody,
>>
>> I'm converting an ethernet driver to use phylib, and I have an  
>> interrupt
>> question.  My device is an integrated mac/phy, with the option to  
>> disable
>> the internal phy and use an external phy instead.  I've succesfully  
>> used
>> phylib in polling mode, but I'd like to convert this to be
>> interrupt-driven if possible.
>>
>> When using the internal phy, it can raise interrupts via the mac (by
>> setting a "phy interrupt" bit in the mac's interrupt status  
>> register).  Is
>> there a way of signalling this phy interrupt to phylib from my mac
>> driver's isr?  Phylib seems to want to connect to a real irq?
>
> Hm.  Looks like one of the features of Phylib got accidentally  
> dropped.  However, it's a simple 2-line fix which I'm about to submit.


D'oh, I'm totally wrong about that being a bug.  Both of the places  
that check phydev->irq != PHY_POLL are valid.  Good news is: that  
means you don't need to wait for a patch!

Andy
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ