netdev - Re: pppoe: Unshare skb before anything else

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <484BAFBB.6010108@katalix.com>
Date:	Sun, 08 Jun 2008 11:08:59 +0100
From:	James Chapman <jchapman@...alix.com>
To:	Herbert Xu <herbert@...dor.apana.org.au>
CC:	"David S. Miller" <davem@...emloft.net>, netdev@...r.kernel.org
Subject: Re: pppoe: Unshare skb before anything else

Herbert Xu wrote:
> Hi Dave:
> 
> I noticed that my last patch to move the unshare in pppoe missed
> the other spot which did the same thing:
> 
> pppoe: Unshare skb before anything else
> 
> We need to unshare the skb first as otherwise pskb_may_pull may
> write to a shared skb which could be bad.

The same problem exists in the pppol2tp driver. Patch to follow. I'm 
also fixing the copy-to-iovec issue.

-- 
James Chapman
Katalix Systems Ltd
http://www.katalix.com
Catalysts for your Embedded Linux software development

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html