netdev - Re: [patch] bondig - arp_interval with low value => Oops.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <484F02A0.7010009@garzik.org>
Date:	Tue, 10 Jun 2008 18:39:28 -0400
From:	Jeff Garzik <jeff@...zik.org>
To:	Jay Vosburgh <fubar@...ibm.com>
CC:	Nicolas 2P <nicolas.2p.debian@...e.fr>,
	David Miller <davem@...emloft.net>,
	bonding-devel@...ts.sourceforge.net, linux-net@...r.kernel.org,
	linux-kernel@...r.kernel.org, netdev@...r.kernel.org
Subject: Re: [patch] bondig - arp_interval with low value => Oops.

Jay Vosburgh wrote:
> Jeff Garzik <jeff@...zik.org> wrote:
> 
>> Nicolas 2P wrote:
>>> When setting arp_interval parameter to a very low value, delta_in_ticks
>>> for next arp might become 0, causing an infinite loop.
>>>
>>> See http://bugzilla.kernel.org/show_bug.cgi?id=10680
>>>
>>> Same problem for miimon parameter already fixed, but fix might be
>>> enhanced, by using msecs_to_jiffies() function.
>>>
>>> Signed-off-by: Nicolas de Pesloüan <nicolas.2p.debian@...e.fr>
>> I don't see an ACK from Jay in my mbox?
>>
>> Certainly looks nicer than adding "? : 1" to each of the remaining two
>> cases.
> 
> 	This was accepted a couple of weeks ago; I had to fix a bug in
> the patch, so I'd guess you didn't connect them:
> 
> commit 5ce0da8f0386b62345312ec8fed31303732f4220
> Author: Jay Vosburgh <fubar@...ibm.com>
> Date:   Sat May 17 21:10:07 2008 -0700
> 
>     bonding: Use msecs_to_jiffies, eliminate panic

Great, thanks!


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html