netdev - Re: Oops in nf_nat_core.c:find_appropriate

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 10 Jun 2008 11:02:59 +0200
From:	Patrick McHardy <kaber@...sh.net>
To:	Chuck Ebbert <cebbert@...hat.com>
CC:	Krzysztof Oledzki <ole@....pl>, Netdev <netdev@...r.kernel.org>,
	Netfilter Development Mailinglist 
	<netfilter-devel@...r.kernel.org>
Subject: Re: Oops in nf_nat_core.c:find_appropriate_src(), kernel 2.6.25.4

Krzysztof Oledzki wrote:
> On Sat, 7 Jun 2008, Patrick McHardy wrote:
> 
>> Patrick McHardy wrote:
>>> Chuck Ebbert wrote:
>>>> Reported at https://bugzilla.redhat.com/show_bug.cgi?id=449315
>>>>
>>>> In find_appropriate_src():
>>>>
>>>>         hlist_for_each_entry_rcu(nat, n, &bysource[h], bysource) {
>>>>                 ct = nat->ct;
>>>>                 if (same_src(ct, tuple)) {
>>>>
>>>> Dereference of ct in same_src() causes the oops. This only seems to
>>>> happen on heavily loaded firewall machines. Kernel 2.6.24.7 works.
>>>>
>>>> The reporter identifies commit 4d354c5782dc352cec187845d17eedc2c2bfcf67
>>>> ("[NETFILTER]: nf_nat: use RCU for bysource hash") as a possible cause
>>>> of the problem.
>>>
>>> We have a similar looking report, but that one also affects 2.6.24:
>>>
>>> http://bugzilla.kernel.org/show_bug.cgi?id=10875


We found the reason for that crash and I've queued these two
patches. Please let me know whether they also fix the problem
from the redhat bugzilla.


View attachment "02.diff" of type "text/x-diff" (2905 bytes)

View attachment "03.diff" of type "text/x-diff" (3307 bytes)