[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <20080609171532.32eb5a95.akpm@linux-foundation.org>
Date: Mon, 9 Jun 2008 17:15:32 -0700
From: Andrew Morton <akpm@...ux-foundation.org>
To: Alan Cox <alan@...rguk.ukuu.org.uk>
Cc: jeff@...zik.org, netdev@...r.kernel.org, alan@...hat.com,
randy.dunlap@...cle.com
Subject: Re: [patch 04/13] 8390: Split 8390 support into a pausing and a non
pausing driver core
On Tue, 10 Jun 2008 00:52:47 +0100
Alan Cox <alan@...rguk.ukuu.org.uk> wrote:
> On Mon, 09 Jun 2008 16:33:49 -0700
> akpm@...ux-foundation.org wrote:
>
> > From: Alan Cox <alan@...rguk.ukuu.org.uk>
> >
> > Only a few ISA controllers need the pausing version of the 8390 core
> > while PCMCIA, later ISA and PCI do not. More importantly the ISA delays
> > can break non ISA boxes so we must use a different build of 8390.c for
> > the two sets of controllers.
> >
> > No changes since last time as all the points of concerns raised proved to
> > be invalid
> >
> > [randy.dunlap@...cle.com: ne2 (MCA) needs both 8390.o and 8390p.o functions]
>
> ne2 does not need both, it hasn't needed both and its completely invalid
> to have both in one driver. Please drop Randy's change out and fix the
> actual typo instead.
>
This patch sat in my tree for weeks causing build errors, then Randy
sent a fix and after that it didn't cause any build errors any more.
I do not know what typo you are referring to.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists