netdev - Re: pppoe: Unshare skb before anything else

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20080610.150116.49258090.davem@davemloft.net>
Date:	Tue, 10 Jun 2008 15:01:16 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	jchapman@...alix.com
Cc:	herbert@...dor.apana.org.au, netdev@...r.kernel.org
Subject: Re: pppoe: Unshare skb before anything else

From: James Chapman <jchapman@...alix.com>
Date: Tue, 10 Jun 2008 22:44:02 +0100

> David Miller wrote:
> > From: James Chapman <jchapman@...alix.com>
> > Date: Sun, 08 Jun 2008 11:08:59 +0100
> > 
> >> Herbert Xu wrote:
> >>> Hi Dave:
> >>>
> >>> I noticed that my last patch to move the unshare in pppoe missed
> >>> the other spot which did the same thing:
> >>>
> >>> pppoe: Unshare skb before anything else
> >>>
> >>> We need to unshare the skb first as otherwise pskb_may_pull may
> >>> write to a shared skb which could be bad.
> >> The same problem exists in the pppol2tp driver. Patch to follow. I'm 
> >> also fixing the copy-to-iovec issue.
> > 
> > I have the iovec patch, but I do not see the unshare one.
> > Did you post it?  Please resend if you have since I
> > don't have a copy.
> 
> I didn't send the patch. I realised when I was writing it that in L2TP's 
> case, the unshare isn't needed because L2TP uses UDP encap sockets.
> 
> Sorry I forgot to let Herbert and netdev know.

Great, thanks for the info.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html