netdev - Re: [PATCH v4 04/14] QLogic VNIC: Implementation of Control path of communication protocol

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080610152147.042b230f@extreme>
Date:	Tue, 10 Jun 2008 15:21:47 -0700
From:	Stephen Hemminger <shemminger@...tta.com>
To:	Ramachandra K <ramachandra.kuchimanchi@...gic.com>
Cc:	rdreier@...co.com, general@...ts.openfabrics.org,
	netdev@...r.kernel.org, poornima.kamath@...gic.com,
	amar.mudrankit@...gic.com
Subject: Re: [PATCH v4 04/14] QLogic VNIC: Implementation of Control path of
 communication protocol

On Tue, 10 Jun 2008 17:04:15 -0400
Ramachandra K <ramachandra.kuchimanchi@...gic.com> wrote:

> +#ifdef CONFIG_INFINIBAND_QLGC_VNIC_STATS
> +	struct {
> +		cycles_t	request_time;	/* intermediate value */
> +		cycles_t	response_time;
> +		u32		response_num;
> +		cycles_t	response_max;
> +		cycles_t	response_min;
> +		u32		timeout_num;
> +	} statistics;

Shouldn't you be using ktime_t rather than cycles_t? And then convert
it to some standard time base (ns, ms, or USER_HZ) when reporting
to user space.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html