netdev - Re: [PATCH 2/2] ixgbe: add LRO support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20080611101628.GQ11300@solarflare.com>
Date:	Wed, 11 Jun 2008 11:16:29 +0100
From:	Ben Hutchings <bhutchings@...arflare.com>
To:	Malli <mchilakala@...il.com>
Cc:	Jeff Kirsher <jeffrey.t.kirsher@...el.com>, jeff@...zik.org,
	netdev@...r.kernel.org, e1000-devel@...ts.sourceforge.net
Subject: Re: [PATCH 2/2] ixgbe: add LRO support

Malli wrote:
> Forwarding my reply. It got rejected from netdev list, as it was sent in HTML
> 
> Thanks for your feedback Ben. I'll update the patch with ethtool get
> and set flags. But in packet split mode we still wouldn't want to
> limit this with MAX_SKB_FRAGS because we don't actually add the frags
> to the previous packet.  They just chain them together using the
> frag_list and next pointers in the skb. Let me know if it still
> doesn't address your concern in max aggregation.

Yes, I understood that.  I wasn't sure whether MAX_SKB_FRAGS was also meant
to be a limit on the frag_list.  The comment above its definition implies
quite strongly that it isn't, so there's no problem.

Ben.

-- 
Ben Hutchings, Senior Software Engineer, Solarflare Communications
Not speaking for my employer; that's the marketing department's job.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html