netdev - Re: [PATCH 05/26] IPVS: Use new address family specific debugging macros.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4850080D.30306@trash.net>
Date:	Wed, 11 Jun 2008 19:14:53 +0200
From:	Patrick McHardy <kaber@...sh.net>
To:	"Julius R. Volz" <juliusv@...gle.com>
CC:	lvs-devel@...r.kernel.org, netdev@...r.kernel.org,
	horms@...ge.net.au, davem@...emloft.net, vbusam@...gle.com
Subject: Re: [PATCH 05/26] IPVS: Use new address family specific debugging
 macros.

Julius R. Volz wrote:
> Change debug output to use address family specific debugging macros where
> appropriate.
>
> -		IP_VS_ERR("request control DEL for uncontrolled: "
> -			  "%d.%d.%d.%d:%d to %d.%d.%d.%d:%d\n",
> -			  NIPQUAD(cp->caddr),ntohs(cp->cport),
> -			  NIPQUAD(cp->vaddr),ntohs(cp->vport));
> +		IP_VS_ERR_V4(cp->af, "request control DEL for uncontrolled: "
> +			     "%d.%d.%d.%d:%d to %d.%d.%d.%d:%d\n",
> +			     NIPQUAD(cp->caddr.v4),ntohs(cp->cport),
> +			     NIPQUAD(cp->vaddr.v4),ntohs(cp->vport));
> +
> +		IP_VS_ERR_V6(cp->af, "request control DEL for uncontrolled: "
> +			     NIP6_FMT ":%d to " NIP6_FMT ":%d\n",
> +			     NIP6(cp->caddr.v6),ntohs(cp->cport),
> +			     NIP6(cp->vaddr.v6),ntohs(cp->vport));
> +
>   

This would look at lot cleaner if you'd use a debugging macro that
can take both families.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html