netdev - Re: [PATCH 10/26] IPVS: Add IPv6 handler functions to UDP protocol handler.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <48500902.9080006@trash.net>
Date:	Wed, 11 Jun 2008 19:18:58 +0200
From:	Patrick McHardy <kaber@...sh.net>
To:	"Julius R. Volz" <juliusv@...gle.com>
CC:	lvs-devel@...r.kernel.org, netdev@...r.kernel.org,
	horms@...ge.net.au, davem@...emloft.net, vbusam@...gle.com
Subject: Re: [PATCH 10/26] IPVS: Add IPv6 handler functions to UDP protocol
 handler.

Julius R. Volz wrote:
> Define new IPv6-specific handler functions in UDP protocol handler. Set new
> function pointers in ip_vs_protocol struct to point to these functions.

The last four or five patches could save a lot of duplication
by taking advantage of the fact that only address length and
protocol offset differ. Why don't you move the af-specific logic
to the layer above these handlers and pass the offset to them?


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html