netdev - Re: [PATCH] Fixed NetEm's reorder option

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20080611144918.1668e3d8@extreme>
Date:	Wed, 11 Jun 2008 14:49:18 -0700
From:	Stephen Hemminger <shemminger@...ux-foundation.org>
To:	"Rafael Almeida" <almeidaraf@...il.com>
Cc:	linux-kernel@...r.kernel.org, netdev@...r.kernel.org
Subject: Re: [PATCH] Fixed NetEm's reorder option

On Wed, 11 Jun 2008 17:05:10 -0300
"Rafael Almeida" <almeidaraf@...il.com> wrote:

> I noticed no one said anything about my patch below, did I do
> something terrible wrong? Should I just be more patient?
> 
> On Thu, Jun 5, 2008 at 1:34 AM, Rafael C. de Almeida
> <almeidaraf@...il.com> wrote:
> > The reorder option wasn't working correctly. It would only kick in if
> > the gap option was set. In that case it would only lower the
> > probability of reordering packets because of how the if conditional
> > was stated.
> >
> > This patch separetes the algorithm for reordering with gap from the
> > rest, rendering the code more readable and correct.
> >
> > Signed-off-by: Rafael C. de Almeida <rafaelc@....ufmg.br>

Haven't had time to look at this in detail, and I worry about the impact
of changing assumptions people already have in their scripts.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html