netdev - Re: [PATCH 02/26] IPVS: Change IPVS data structures to support IPv6 addresses.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <485081E8.80102@hp.com>
Date:	Wed, 11 Jun 2008 21:54:48 -0400
From:	Brian Haley <brian.haley@...com>
To:	"Julius R. Volz" <juliusv@...gle.com>
Cc:	lvs-devel@...r.kernel.org, netdev@...r.kernel.org,
	horms@...ge.net.au, davem@...emloft.net, vbusam@...gle.com
Subject: Re: [PATCH 02/26] IPVS: Change IPVS data structures to support IPv6
 addresses.

Julius R. Volz wrote:
> +union ip_vs_addr_user {
> +	__be32			v4;
> +	struct in6_addr		v6;
> +};
> +
> +#ifdef CONFIG_IP_VS_IPV6
> +#define ip_vs_addr		ip_vs_addr_user
> +#define ip_vs_copy_addr(a, b)	do { (a) = (b); } while (0)
> +#else
> +union ip_vs_addr {
> +	__be32			v4;
> +};
> +#define ip_vs_copy_addr(a, b)	do { (a).v4 = (b).v4; } while (0)
> +#endif

You need to use ipv6_addr_copy() with IPv6 addresses.  Some of your 
other patches have this same problem, I found some of them...

-Brian
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html