netdev - Re: [git patches] net driver updates for .27

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <48519E57.3030906@garzik.org>
Date:	Thu, 12 Jun 2008 18:08:23 -0400
From:	Jeff Garzik <jeff@...zik.org>
To:	David Miller <davem@...emloft.net>
CC:	sfr@...b.auug.org.au, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [git patches] net driver updates for .27

David Miller wrote:
> From: Stephen Rothwell <sfr@...b.auug.org.au>
> Date: Thu, 12 Jun 2008 13:38:42 +1000
> 
>> Hi Jeff,
>>
>> On Wed, 11 Jun 2008 22:30:46 -0400 Jeff Garzik <jeff@...zik.org> wrote:
>>> Stephen Rothwell (1):
>>>       [netdrvr] Fix 8390 build breakage
>> That patch is actually from Tony Breeds ..
> 
> Jeff, there is still time to fix this.  If you want, just
> fix up that patch in your tree to get the attribution
> and author field correct, and send me a new pull request.

Did you actually read the commit description?  It's quite clear who 
originated the commit:


commit 0c1aa20fb87b796d904f4d89ad12e5a0c483127b
Author: Stephen Rothwell <sfr@...b.auug.org.au>
Date:   Thu May 29 22:39:28 2008 +1000

     [netdrvr] Fix 8390 build breakage

     From: tony@...eyournoodle.com (Tony Breeds)

     ...

     Signed-off-by: Tony Breeds <tony@...eyournoodle.com>
     Signed-off-by: Jeff Garzik <jgarzik@...hat.com>


It's pretty hard to miss, and it accurately captures the entire audit trail:

1) who sent the patch?
2) who wrote the patch?
3) who committed the patch?

So, you want to eliminate part of that audit trail (#1), making the 
commit audit trail more hidden and opaque?

I respectfully disagree.  We should capture the _entire_ audit trail, 
not hide bits of it.

Full credit is given, as you can see from looking at the commit.

	Jeff



--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html