netdev - Re: [patch 05/13] ipg: fix receivemode IPG_RM_RECEIVEMULTICAST{,HASH} in ipg_nic_set_multicast

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <48508F03.4070506@garzik.org>
Date:	Wed, 11 Jun 2008 22:50:43 -0400
From:	Jeff Garzik <jeff@...zik.org>
To:	akpm@...ux-foundation.org
CC:	netdev@...r.kernel.org, roel.kluin@...il.com, romieu@...zoreil.com
Subject: Re: [patch 05/13] ipg: fix receivemode IPG_RM_RECEIVEMULTICAST{,HASH}
 in ipg_nic_set_multicast_list()

akpm@...ux-foundation.org wrote:
> From: Roel Kluin <roel.kluin@...il.com>
> 
> The branches are dead code.  even when dev->flag IFF_MULTICAST (defined
> 0x1000) is set, dev->flags & IFF_MULTICAST & [boolean] always evaluates to
> 0.
> 
> Signed-off-by: Roel Kluin <roel.kluin@...il.com>
> Cc: Francois Romieu <romieu@...zoreil.com>
> Cc: Jeff Garzik <jeff@...zik.org>
> Signed-off-by: Andrew Morton <akpm@...ux-foundation.org>

applied 5-6



--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html