netdev - Re: [PATCH][RFC] TSO for VLAN devices without VLAN tag insertion

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <48511045.8080805@trash.net>
Date:	Thu, 12 Jun 2008 14:02:13 +0200
From:	Patrick McHardy <kaber@...sh.net>
To:	Ben Hutchings <bhutchings@...arflare.com>
CC:	netdev@...r.kernel.org, linux-net-drivers@...arflare.com
Subject: Re: [PATCH][RFC] TSO for VLAN devices without VLAN tag insertion

Ben Hutchings wrote:
> The SFC4000 controller can set IP header, TCP and UDP checksums in IPv4
> packets, with or without VLAN encapsulation.  However it does not do VLAN
> tag insertion.
> 
> When I try to make TSO work for VLAN devices via the new vlan_features,
> dev_queue_xmit() finds skb->ip_summed == CHECKSUM_PARTIAL &&
> skb->protocol == htons(ETH_P_8021Q) and calls skb_checksum_help(), which
> sets skb->ip_summed = CHECKSUM_NONE.
> 
> This causes netif_needs_gso() to return true when called by
> dev_hard_start_xmit(), and GSO then does its worst.
> 
> Below is a patch which worked for me, but I'm not sure whether it's the
> best way to fix the problem (so I'm not submitting or signing it off yet).


It looks reasonable - I can't think of a different way to handle
this case, although its a bit unfortunate that we have to put this
in dev_queue_xmit().
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html