netdev - Re: [PATCH][ATM] iphase: BUG: sleeping function called from invalid context

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sun, 15 Jun 2008 10:47:34 -0400
From:	"Chas Williams (CONTRACTOR)" <chas@....nrl.navy.mil>
To:	jorge@...2.net
cc:	netdev@...r.kernel.org
Subject: Re: [PATCH][ATM] iphase: BUG: sleeping function called from invalid context

In message <48551280.1090706@...2.net>,"Jorge Boncompte [DTI2]" writes:
>> the lock is necessary to prevent multiple cards from modifying iadev_count
>> at the wrong time since iadev_count is incremented and decremented.
>> it might be simpler to just make a local copy of iadev_count and just
>> always increment iadev_count.  if you fail to init a particular card,
>> you will just leave a hole in ia_dev[].  something like the attached.
>
>	I thought that device initialization inside a driver is serialized. isn't it?

i honestly dont know.  even if it is serialized, that code is just
hideous.  if you had a system with hotplug support, it wouldnt work right.

>	I have a patch that removes iadev and iadev_count enterely that i did not sent because i thought it wouldn't be 
>considered a bug fix. I'll sent it this week.

i would certainly prefer that version.  no matter, how you fix the
problem it is a bug fix.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html