netdev - Re: [PATCH] firmware: convert e100 driver to request

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <48555677.7040209@garzik.org>
Date:	Sun, 15 Jun 2008 13:50:47 -0400
From:	Jeff Garzik <jeff@...zik.org>
To:	David Woodhouse <dwmw2@...radead.org>
CC:	netdev@...r.kernel.org, e1000-devel@...ts.sourceforge.net,
	Auke Kok <auke-jan.h.kok@...el.com>,
	Jaswinder Singh <jaswinderlinux@...il.com>
Subject: Re: [PATCH] firmware: convert e100 driver to request_firmware()

David Woodhouse wrote:
> From: Jaswinder Singh <jaswinderlinux@...il.com>
> 
> Thanks to David Woodhouse for help.
> 
> Signed-off-by: Jaswinder Singh <jaswinderlinux@...il.com>
> Signed-off-by: David Woodhouse <dwmw2@...radead.org>
> ---
> We have assumed that in the no-µcode case, there's no actual _reason_
> for the cb_nop command which e100_setup_ucode() was sending; it's just
> that there was no way for it to simply refrain from sending a command,
> since it returns void.
> 
> Abusing the skb parameter for e100_exec_cb() isn't massively pretty, but
> it should work. We could always add a struct firmware * into 'struct
> nic' if people really object.
> 
> And finally, we've assumed that aborting is the correct thing to do when
> the µcode can't be loaded. Should we instead just complain and move on? 
> 
>  drivers/net/Kconfig                |    8 +
>  drivers/net/e100.c                 |  283 +++++++++++-------------------------
>  firmware/Makefile                  |    2 +
>  firmware/WHENCE                    |   12 ++
>  firmware/e100/d101m_ucode.bin.ihex |   38 +++++
>  firmware/e100/d101s_ucode.bin.ihex |   38 +++++
>  firmware/e100/d102e_ucode.bin.ihex |   38 +++++
>  7 files changed, 222 insertions(+), 197 deletions(-)
>  create mode 100644 firmware/e100/d101m_ucode.bin.ihex
>  create mode 100644 firmware/e100/d101s_ucode.bin.ihex
>  create mode 100644 firmware/e100/d102e_ucode.bin.ihex

NAK - firmware should not be stored in a separate directory from the 
driver to which it is intimately tied.


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html