netdev - Re: [PATCH 0/2] Disable forwarding of LRO skbs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20080615033819.GA25133@gondor.apana.org.au>
Date:	Sun, 15 Jun 2008 13:38:19 +1000
From:	Herbert Xu <herbert@...dor.apana.org.au>
To:	Ben Hutchings <bhutchings@...arflare.com>
Cc:	davem@...emloft.net, kmansley@...arflare.com,
	shemminger@...tta.com, netdev@...r.kernel.org
Subject: Re: [PATCH 0/2] Disable forwarding of LRO skbs

On Sun, Jun 15, 2008 at 02:46:58AM +0100, Ben Hutchings wrote:
>
> > Can we distinguish them by testing skb->ip_summed == CHECKSUM_PARTIAL?
> > That is a requirement for using hardware segmentation offload (see
> > netif_needs_gso()) but an skb resulting from LRO should have ip_summed
> > set to either CHECKSUM_UNNECESSARY or CHECKSUM_NONE.
> 
> Actually, it seems like there's a cleaner test: gso_size != 0 &&
> gso_type == 0 (if we really want GSO then the latter must be set).
> I'll have to try that out.

Yeah either way should work.

Cheers,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html