netdev - Re: RFC: [PATCH 2/3] netdevice: Fix promiscuity and allmulti overflow

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <48563AC9.3000008@trash.net>
Date:	Mon, 16 Jun 2008 12:04:57 +0200
From:	Patrick McHardy <kaber@...sh.net>
To:	Wang Chen <wangchen@...fujitsu.com>
CC:	"David S. Miller" <davem@...emloft.net>,
	NETDEV <netdev@...r.kernel.org>
Subject: Re: RFC: [PATCH 2/3] netdevice: Fix promiscuity and allmulti overflow

Wang Chen wrote:
> Patrick McHardy said the following on 2008-6-16 17:38:
>>
>> I question the need for this though, userspace can only trigger
>> an increase/decrease by one no matter how often it enables
>> the ALLMULTI/PROMISC flags, and I doubt any codepath in the
>> kernel would lead to an overflow.
>>
> 
> How about mif6_add()?
> Do we have a limit for mif6?

No, so I guess your patch makes sense.

>> If this can really happen it would be better to leave the
>> counter untouched and return an error, we already have too
>> many device operations that might fail more or less silently.
>>
> 
> This can be done.

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html