netdev - Re: [PATCH] firmware: convert acenic driver to request

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <18518.37862.812419.353804@jaguar.mkp.net>
Date:	Mon, 16 Jun 2008 12:25:10 -0400
From:	jes@...ined-monkey.org (Jes Sorensen)
To:	David Woodhouse <dwmw2@...radead.org>
Cc:	netdev@...r.kernel.org, jaswinder@...radead.org
Subject: Re: [PATCH] firmware: convert acenic driver to request_firmware()

>>>>> "David" == David Woodhouse <dwmw2@...radead.org> writes:

David> Again with help from Jaswinder Singh.  Omitting the large part of
David> the patch which actually moves the firmware around, since you'll
David> need to pull from the git tree to get the preceding patches if
David> you want to test it anyway.

David> We store the firmware in little-endian form now, and thus use
David> __raw_writel() to write it to the device, to avoid byteswapping
David> by writel(). I've revamped that loop in ace_copy() a little bit
David> so it could probably do with being tested.

Mmmmm,

I am not particular bothered as to whether or not to put the firmware to
userspace or not, however has this patch been tested on big endian
systems? Given that the card is big endian, how is this going to affect
big endian systems?

Honestly, I think it's a bad idea to start messing with the byte order
of the data for something that happens once at boot time.

Cheers,
Jes
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html