netdev - Re: [PATCH 2/2] fs_enet: MDIO on GPIO support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080616163400.GA13996@loki.buserror.net>
Date:	Mon, 16 Jun 2008 11:34:00 -0500
From:	Scott Wood <scottwood@...escale.com>
To:	Laurent Pinchart <laurentp@...-semaphore.com>
Cc:	linuxppc-dev@...abs.org, netdev@...r.kernel.org, jgarzik@...ox.com,
	vbordug@...mvista.com, pantelis.antoniou@...il.com
Subject: Re: [PATCH 2/2] fs_enet: MDIO on GPIO support

On Mon, Jun 16, 2008 at 10:57:02AM +0200, Laurent Pinchart wrote:
> On Monday 26 May 2008 11:53, Laurent Pinchart wrote:
> > Port the fs_enet driver to support the MDIO on GPIO driver for PHY access
> > in addition to the mii-bitbang driver.
> 
> Now that 1/2 has been applied by Jeff, could this one make it to 
> powerpc-next ?

This patch should probably go through Jeff as well...

Acked-by: Scott Wood <scottwood@...escale.com>

> > -	data = of_get_property(phynode, "reg", &len);
> > -	if (!data || len != 4)
> > -		goto out_put_mdio;
> > +	bus_id = of_get_gpio(mdionode, 0);
> > +	if (bus_id < 0) {
> > +		struct resource res;
> > +		ret = of_address_to_resource(mdionode, 0, &res);
> > +		if (ret)
> > +			goto out_put_mdio;
> > +		bus_id = res.start;
> > +	}
> >  
> > -	snprintf(fpi->bus_id, 16, "%x:%02x", res.start, *data);
> > +	snprintf(fpi->bus_id, 16, "%x:%02x", bus_id, *data);

It'd be nice if this sort of thing could be moved to phylib, so the latter
could simply be passed a device node (in addition to current mechanisms for
the benefit of unfortunate device-tree-less architectures).

-Scott
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html