netdev - [PATCH net-2.6 6/7] atm: [he] limit queries to the device's register space

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <200806161727.m5GHRo6N003390@cmf.nrl.navy.mil>
Date:	Mon, 16 Jun 2008 13:27:50 -0400
From:	"chas williams - CONTRACTOR" <chas@....nrl.navy.mil>
To:	netdev@...r.kernel.org
Cc:	davem@...emloft.net
Subject: [PATCH net-2.6 6/7] atm: [he] limit queries to the device's register space

commit 75e7637e840b7b3ec97df6e04357d607a2aee077
Author: "Robert T. Johnson" <rtjohnso@...s.berkeley.edu>
Date:   Sat Jun 14 17:40:16 2008 -0400

    atm: [he] limit queries to the device's register space
    
    From: "Robert T. Johnson" <rtjohnso@...s.berkeley.edu>
    Signed-off-by: Chas Williams <chas@....nrl.navy.mil>

diff --git a/drivers/atm/he.c b/drivers/atm/he.c
index 88034d9..cd58cd3 100644
--- a/drivers/atm/he.c
+++ b/drivers/atm/he.c
@@ -2693,10 +2693,15 @@ he_ioctl(struct atm_dev *atm_dev, unsigned int cmd, void __user *arg)
 			if (copy_from_user(&reg, arg,
 					   sizeof(struct he_ioctl_reg)))
 				return -EFAULT;
-			
+
 			spin_lock_irqsave(&he_dev->global_lock, flags);
 			switch (reg.type) {
 				case HE_REGTYPE_PCI:
+					if (reg.addr < 0 || reg.addr >= HE_REGMAP_SIZE) {
+						err = -EINVAL;
+						break;
+					}
+					
 					reg.val = he_readl(he_dev, reg.addr);
 					break;
 				case HE_REGTYPE_RCM:
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html