netdev - Re: [PATCH,RFC] skb->network_header and __vlan_put

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4857ABDA.6050407@trash.net>
Date:	Tue, 17 Jun 2008 14:19:38 +0200
From:	Patrick McHardy <kaber@...sh.net>
To:	Benny Amorsen <benny+usenet@...rsen.dk>
CC:	netdev@...r.kernel.org, Lennert Buytenhek <buytenh@...tstofly.org>
Subject: Re: [PATCH,RFC] skb->network_header and __vlan_put_tag()

[Don't trim CC lists please]

Benny Amorsen wrote:
> Lennert Buytenhek <buytenh@...tstofly.org> writes:
> 
>> I'm adding VLAN support to mv643xx_eth (which does not support HW
>> insertion of a VLAN tag, but it does support HW checksumming when
>> a VLAN tag is present, you just have to tell the HW how many bytes
>> there are between the start of the packet and the IP header), and
>> I'm ending up with code like this:
>>
>> 	if (skb->protocol == htons(ETH_P_8021Q))
>> 		ip_header = ip_hdr(skb) + 4;
>> 	else
>> 		ip_header = ip_hdr(skb);
> 
> How well does this work when doing QinQ or QinQinQ?

Currently probably doesn't work, so the patch makes even more
sense.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html