netdev - Re: [PATCH 0/2] HTB scheduler HTB

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20080617005938.M55099@visp.net.lb>
Date:	Tue, 17 Jun 2008 04:00:19 +0300
From:	"Denys Fedoryshchenko" <denys@...p.net.lb>
To:	David Miller <davem@...emloft.net>, devik@....cz
Cc:	jdb@...x.dk, netdev@...r.kernel.org, kaber@...sh.net
Subject: Re: [PATCH 0/2] HTB scheduler HTB_HYSTERESIS modifications

On Mon, 16 Jun 2008 16:40:32 -0700 (PDT), David Miller wrote
> From: Martin Devera <devik@....cz>
> Date: Sat, 14 Jun 2008 11:18:00 +0200
> 
> > > I have now tested/deployed the patches on two production servers.
> > > 
> > >  Conclusion is: It should be safe to apply these patches.
> > > 
> > > See full report here:
> > >
http://people.netfilter.org/hawk/patches/htb_nohyst/production_test_results.html
> > > 
> > > We saw an increased number of interrupts on the test system, when
> > > enabling/disabling htb_hysteresis.
> > > 
> > >  This didn't show up on the production system.
> > > 
> > > I believe that the increased intr (on test system) is an artifact of the
> > > TCP download got less bursty and more smooth.
> > 
> > Which reminds me again, maybe after some time with hysteresis=off we 
> > could remove it altogether...
> > 
> > Sorry for the delay, I got some flu or what. On my smaller dualcore 
> > system there is also no noticeable (performance) impact.
> > 
> > I ACK Jesper's patches, thanks for the work and real-world testing!
> 
> I've applied Jesper's work to net-2.6, as it is primarily a bug
> fix of sorts and safe because a backwards compatible knob is
> provided just in case it does cause problems for people.
> 
> Thanks everyone!

I test this patch too, works fine on loaded system. No significant load
increase, works perfect.

--
Denys Fedoryshchenko
Technical Manager
Virtual ISP S.A.L.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html