netdev - Re: bnx2_poll panicking kernel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080617223708.GA30292@orion.carnet.hr>
Date:	Wed, 18 Jun 2008 00:37:08 +0200
From:	Josip Rodin <joy@...uzijast.net>
To:	Michael Chan <mchan@...adcom.com>
Cc:	Ben Hutchings <bhutchings@...arflare.com>,
	netdev <netdev@...r.kernel.org>, mirrors@...ian.org
Subject: Re: bnx2_poll panicking kernel

On Mon, Jun 16, 2008 at 04:45:08PM -0700, Michael Chan wrote:
> On Mon, 2008-06-16 at 23:48 +0200, Josip Rodin wrote:
> > > Crap, it just crashed again, with 2.6.25.6.
> 
> Looking at the panic dmesg, I believe it was crashing because skb was
> NULL in bnx2_tx_int().
> 
> > 
> > I should mention that I might have a clue - around the time the crashes
> > started, I started using HTB with the following configuration:
> 
> This rings a bell.  A similar crash was reported by a user using HTB on
> a tg3 device.  After some analysis, my suspicion was that the shinfo
> (skb)->nr_frags on the TX packet was corrupted before the SKB was freed
> by the driver.  In both the tg3 and bnx2 drivers, we rely on the
> nr_frags to locate the TX packet boundaries on the ring to free the
> packets.
> 
> Please try this debug patch below.  If the theory is correct, the patch
> should avoid the crash and will print something to the dmesg log every
> time a crash is avoided.  Please run it again with the HTB rules and
> send me the dmesg log containing:
> 
> bnx2: skb->nr_frags ...
> 
> Here's the debug patch below.  It saves the nr_frags from the SKB and
> uses it to locate the packet boundaries instead.  It will also compare
> the saved value with the one in SKB and print a warning when they don't
> match.  Please apply to 2.6.25.6.

After applying this patch, two rsync runs went through without any problem,
yay.

Yet, there were no alerts from the new printk in the patch...?

-- 
     2. That which causes joy or happiness.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html