netdev - Re: [PATCH net-next 0/8] netns: optimize tcp and udp hashtables wrt net namespaces

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20080616.171459.40244811.davem@davemloft.net>
Date:	Mon, 16 Jun 2008 17:14:59 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	xemul@...nvz.org
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH net-next 0/8] netns: optimize tcp and udp hashtables
 wrt net namespaces

From: Pavel Emelyanov <xemul@...nvz.org>
Date: Mon, 16 Jun 2008 13:35:32 +0400

> Currently hash functions to store udp sockets, bind buckets,
> listening and established tcp sockets take only ports and/or
> addresses into account.
> 
> The result is nasty. Consider processes in different namespaces
> communicate to each other or the outer world with same ports 
> or addresses (e.g. dns server run in each namespace, apache server
> listening a 80 port in each ns or communications via lo). All 
> these sockets will all be linked in a single hash chain, thus 
> producing too long chains.
> 
> To avoid this situation the proposal is to add some "salt" to
> hash functions taking the namespace into account.
> 
> I made this "salt" disappear for CONFIG_NET_NS=n case.
> 
> Signed-off-by: Pavel Emelyanov <xemul@...nvz.org>

Looks great.  I've applied this to net-next-2.6 and will push
back out to kernel.org after some build testing.

Thanks!
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html