netdev - Re: [PATCH] [UPDATED] ixgbe: add LRO support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <48588933.2060605@garzik.org>
Date:	Wed, 18 Jun 2008 00:04:03 -0400
From:	Jeff Garzik <jeff@...zik.org>
To:	Jeff Kirsher <jeffrey.t.kirsher@...el.com>
CC:	netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
	davem@...emloft.net, randy.dunlap@...cle.com
Subject: Re: [PATCH] [UPDATED] ixgbe: add LRO support

Jeff Kirsher wrote:
> From: Mallikarjuna R Chilakala <mallikarjuna.chilakala@...el.com>
> 
> Support for in-kernel LRO with the ability to enable/disable via ethtool
> based on comments from Ben Hutchings and Randy Dunlap.
> 
> Signed-off-by: Mallikarjuna R Chilakala <mallikarjuna.chilakala@...el.com>
> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@...el.com>
> Signed-off-by: PJ Waskiewicz <peter.p.waskiewicz.jr@...el.com>
> ---
> 
>  drivers/net/Kconfig               |    3 +
>  drivers/net/ixgbe/ixgbe.h         |    9 +++
>  drivers/net/ixgbe/ixgbe_ethtool.c |   11 ++++
>  drivers/net/ixgbe/ixgbe_main.c    |  111 ++++++++++++++++++++++++++++++-------
>  4 files changed, 112 insertions(+), 22 deletions(-)


I take that back.

This patch has a bunch of checkpatch problems, and it doesn't even 
compile, so it obviously was not tested:

drivers/net/ixgbe/ixgbe_main.c: In function ‘ixgbe_receive_skb’:
drivers/net/ixgbe/ixgbe_main.c:416: error: implicit declaration of 
function ‘vlan_nw_accel_receive_skb’

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html