netdev - Re: v2: [PATCH 2/3] netdevice: Fix promiscuity and allmulti overflow

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20080617.215402.169100957.davem@davemloft.net>
Date:	Tue, 17 Jun 2008 21:54:02 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	wangchen@...fujitsu.com
Cc:	kaber@...sh.net, netdev@...r.kernel.org
Subject: Re: v2: [PATCH 2/3] netdevice: Fix promiscuity and allmulti
 overflow

From: Wang Chen <wangchen@...fujitsu.com>
Date: Wed, 18 Jun 2008 09:51:00 +0800

> Patrick McHardy said the following on 2008-6-17 20:59:
> >> +            printk(KERN_ERR "%s: promiscuity touches roof, "
> >> +                "set promiscuity failed, promiscuity feature "
> >> +                "of device will be broken.\n", dev->name);
> >> +            return -EOVERFLOW;
> >> +        }
> >> +    }
> > 
> > Assuming the caller does proper error handling, that printk is
> > not true.
> > 
> 
> Yes.
> But currently, no caller handling this, and I think even if I make
> some callers to handle this, but there maybe some callers and their
> callers do not want to handle error condition.
> So I need a KERN_WARNING here.
> If some day, all of the caller handle the error properly, we can
> remove this printk.
> 
> Here is v3:

Patrick, ACK?
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html