netdev - Re: [PATCH 1/2] fs_enet: fix checkpatch.pl problems

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 17 Jun 2008 23:20:21 -0600
From:	"Grant Likely" <grant.likely@...retlab.ca>
To:	"John Rigby" <jrigby@...escale.com>
Cc:	"Scott Wood" <scottwood@...escale.com>, linuxppc-dev@...abs.org,
	jeff@...zik.org, "Sam Ravnborg" <sam@...nborg.org>,
	netdev@...r.kernel.org
Subject: Re: [PATCH 1/2] fs_enet: fix checkpatch.pl problems

On Tue, Jun 17, 2008 at 5:03 PM, John Rigby <jrigby@...escale.com> wrote:
> Fixed all errors and warnings that checkpatch.pl
> reports if this was a new submission.
> Also changed instances of fec_t to struct fec in
> mac-fec.c and mii-fec.c.

Nit: checkpatch is not law; particularly in the case of whitespace
change.  Personally, I think cleaning up whitespace in this regard
causes more problems than it solves.  Plus, it makes the important
change (fec_t -> struct fec) get lost in a see of unimportant ones
which makes for hard reviewing.

But I must sleep now; I'll review your other patch tomorrow.

Cheers,
g.

-- 
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html