netdev - Re: [PATCH 3/8] bnx2: Optimize fast-path tx and rx work.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20080619.164121.98886728.davem@davemloft.net>
Date:	Thu, 19 Jun 2008 16:41:21 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	mchan@...adcom.com
Cc:	netdev@...r.kernel.org, benli@...adcom.com
Subject: Re: [PATCH 3/8] bnx2: Optimize fast-path tx and rx work.

From: "Michael Chan" <mchan@...adcom.com>
Date: Wed, 18 Jun 2008 17:25:27 -0700

> Add hw_tx_cons_ptr and hw_rx_cons_ptr to speed up the retreival of
> the tx and rx consumer index, since the MSI-X and default status
> blocks have different structures.
> 
> Combine status_blk and status_blk_msix into a union.  We'll only use
> one type of status block for each vector.
> 
> Separate the code to detect more rx and tx work from the code to
> detect link related work.
> 
> Signed-off-by: Michael Chan <mchan@...adcom.com>
> Signed-off-by: Benjamin Li <benli@...adcom.com>

This adds a new warning:

drivers/net/bnx2.c: In function ‘bnx2_poll_link’:
drivers/net/bnx2.c:3164: warning: no return statement in function returning non-void

So I changed bnx2_poll_link() to return 'void' when
checking this in.