netdev - Re: [PATCH 3/12] benet: net_object i/f functions, Makefile

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20080619091135.GA11101@infradead.org>
Date:	Thu, 19 Jun 2008 05:11:35 -0400
From:	Christoph Hellwig <hch@...radead.org>
To:	Subbu Seetharaman <subbus@...verengines.com>
Cc:	Sam Ravnborg <sam@...nborg.org>, jeff@...zik.org,
	netdev@...r.kernel.org, sathyap@...verengines.com
Subject: Re: [PATCH 3/12] benet: net_object i/f functions, Makefile

On Wed, Jun 18, 2008 at 11:27:01PM -0700, Subbu Seetharaman wrote:
> We could not get KBUILD_EXTRA_SYMBOLS to work.
> This  is what we did :
> 
> beclib's Module.symvers has entries like this :
> 
> 0x00000000      be_eq_destroy   /home/subbu/kod39-sperla/drivers/message/beclib/beclib  EXPORT_SYMBOL 
> 
> benet uses exports from beclib and we have the following line in benet's Makefile: 
> KBUILD_EXTRA_SYMBOLS = $(src)/../../message/beclib/Module.symvers 
> 
> When we build benet we still get warnings like this
> for symbols defined and exported from beclib :
> WARNING: "be_eq_destroy" [/home/subbu/kod39-sperla/drivers/net/benet/benet.ko] undefined! 
> 


The righ answer is of course to kill all this beclib junk and write
a proper linux driver.  We're made it pretty clear a few times in the
past that these abstraction layers don't go in.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html