netdev - Re: [PATCH 3/12] benet: net_object i/f functions, Makefile

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20080619100151.GA24434@infradead.org>
Date:	Thu, 19 Jun 2008 06:01:51 -0400
From:	Christoph Hellwig <hch@...radead.org>
To:	Subbu Seetharaman <subbus@...verengines.com>
Cc:	Christoph Hellwig <hch@...radead.org>,
	Sam Ravnborg <sam@...nborg.org>, jeff@...zik.org,
	netdev@...r.kernel.org, sathyap@...verengines.com
Subject: Re: [PATCH 3/12] benet: net_object i/f functions, Makefile

On Thu, Jun 19, 2008 at 02:59:19AM -0700, Subbu Seetharaman wrote:
> Christoph,
> 
> The primary reason for separating the lower layer
> code from rest of the driver is to share it
> across two drivers for the two functions
> of the device.

Then please look at the various drivers that already do this.  Just
built each module on it's own without strange cross-directory builds.

> The secondary objective of
> keeping this code OS neutral through 
> abstractions has been conceded based
> on the review comments from the last few 
> rounds.

But that's not how the code looks like.  There's still tons and tons
of useless wrappers that just make the code unreadable.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html