netdev - Re: [PATCH] fs_enet: restore promiscuous and multicast settings in restart()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 19 Jun 2008 23:41:33 +0400
From:	"Matvejchikov Ilya" <matvejchikov@...il.com>
To:	"Vitaly Bordug" <vbordug@...mvista.com>
Cc:	"Laurent Pinchart" <laurentp@...-semaphore.com>,
	linuxppc-dev@...abs.org, netdev@...r.kernel.org,
	pantelis.antoniou@...il.com
Subject: Re: [PATCH] fs_enet: restore promiscuous and multicast settings in restart()

Yes, please. =)

2008/6/19 Vitaly Bordug <vbordug@...mvista.com>:
> On Wed, 18 Jun 2008 22:45:57 +0400
> "Matvejchikov Ilya" <matvejchikov@...il.com> wrote:
>
>> I'm glad that you have corrected it. Half a year ago I pointed out
>> that there was such a mistake:
>> http://patchwork.ozlabs.org/linuxppc/patch?id=10700
>>
> You've used -embedded ML, and patch wasn't noticed... I can add your S-O-B line if that will make you fill better :)
>
> -Vitaly
>> Thanks.
>>
>> 2008/6/18 Laurent Pinchart <laurentp@...-semaphore.com>:
>> > The restart() function is called when the link state changes and resets
>> > multicast and promiscous settings. This patch restores those settings at the
>> > end of restart().
>> >
>> > Signed-off-by: Laurent Pinchart <laurentp@...-semaphore.com>
>> > ---
>> >  drivers/net/fs_enet/mac-fcc.c     |    3 +++
>> >  2 files changed, 4 insertions(+), 1 deletions(-)
>> >
>> > diff --git a/drivers/net/fs_enet/mac-fcc.c b/drivers/net/fs_enet/mac-fcc.c
>> > index ce40cf9..1a95cf1 100644
>> > --- a/drivers/net/fs_enet/mac-fcc.c
>> > +++ b/drivers/net/fs_enet/mac-fcc.c
>> > @@ -464,6 +464,9 @@ static void restart(struct net_device *dev)
>> >                C32(fccp, fcc_fpsmr, FCC_PSMR_FDE | FCC_PSMR_LPB);
>> >
>> >        S32(fccp, fcc_gfmr, FCC_GFMR_ENR | FCC_GFMR_ENT);
>> > +
>> > +       /* Restore multicast and promiscous settings */
>> > +       set_multicast_list(dev);
>> >  }
>> >
>> >  static void stop(struct net_device *dev)
>> > --
>> > 1.5.0
>> >
>> > --
>> > Laurent Pinchart
>> > CSE Semaphore Belgium
>> >
>> > Chaussee de Bruxelles, 732A
>> > B-1410 Waterloo
>> > Belgium
>> >
>> > T +32 (2) 387 42 59
>> > F +32 (2) 387 42 75
>> >
>
>
> --
> Sincerely,
> Vitaly
>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html