netdev - RE: [PATCH 2/2] net: Discard and warn about LRO'd skbs received for forwarding

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <36D9DB17C6DE9E40B059440DB8D95F5205732065@orsmsx418.amr.corp.intel.com>
Date:	Thu, 19 Jun 2008 15:29:05 -0700
From:	"Brandeburg, Jesse" <jesse.brandeburg@...el.com>
To:	"Stephen Hemminger" <shemminger@...tta.com>,
	"Ben Hutchings" <bhutchings@...arflare.com>
Cc:	"David Miller" <davem@...emloft.net>, <netdev@...r.kernel.org>,
	<linux-net-drivers@...arflare.com>,
	"Kieran Mansley" <kmansley@...arflare.com>,
	"Herbert Xu" <herbert@...dor.apana.org.au>
Subject: RE: [PATCH 2/2] net: Discard and warn about LRO'd skbs received for forwarding

Stephen Hemminger wrote:
> On Thu, 19 Jun 2008 19:08:34 +0100
> Ben Hutchings <bhutchings@...arflare.com> wrote:
> 
>> Add skb_warn_if_lro() to test whether an skb was received with LRO
>> and warn if so. 
>> 
>> Change br_forward(), ip_forward() and ip6_forward() to call it) and
>> discard the skb if it returns true.
> 
> Actually shouldn't ip forwarding work because of refragmentation?

Yes, it should, but in practice it runs out of fragment handling space
and throughput drops to 10kB/s or something horrible like that, AFAIR.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html