netdev - Re: [PATCH 1/2] net: Disable LRO on devices that are forwarding

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20080619.162145.212568056.davem@davemloft.net>
Date:	Thu, 19 Jun 2008 16:21:45 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	bhutchings@...arflare.com
Cc:	netdev@...r.kernel.org, linux-net-drivers@...arflare.com,
	kmansley@...arflare.com, herbert@...dor.apana.org.au,
	shemminger@...tta.com
Subject: Re: [PATCH 1/2] net: Disable LRO on devices that are forwarding

From: Ben Hutchings <bhutchings@...arflare.com>
Date: Thu, 19 Jun 2008 19:07:36 +0100

> Large Receive Offload (LRO) is only appropriate for packets that are
> destined for the host, and should be disabled if received packets may be
> forwarded.  It can also confuse the GSO on output.
> 
> Add dev_disable_lro() function which uses the appropriate ethtool ops to
> disable LRO if enabled.
> 
> Add calls to dev_disable_lro() in br_add_if() and functions that enable
> IPv4 and IPv6 forwarding.
> 
> Signed-off-by: Ben Hutchings <bhutchings@...arflare.com>

Looks good, applied to net-next-2.6
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html