| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <485B1ECE.7080106@cn.fujitsu.com> Date: Fri, 20 Jun 2008 11:06:54 +0800 From: Wang Chen <wangchen@...fujitsu.com> To: David Miller <davem@...emloft.net> CC: yoshfuji@...ux-ipv6.org, netdev@...r.kernel.org, kaber@...sh.net Subject: Re: [PATCH net-next 5/8] ipv6: Check return of dev_set_allmulti David Miller said the following on 2008-6-20 10:09: > Please delete comment. allmulti might overflow. Commit: "netdevice: Fix promiscuity and allmulti overflow" in net-next makes dev_set_promiscuity/allmulti return error number if overflow happened. Here, we check the positive increment for allmulti to get error return. Signed-off-by: Wang Chen <wangchen@...fujitsu.com> --- net/ipv6/ip6mr.c | 5 ++++- 1 files changed, 4 insertions(+), 1 deletions(-) diff --git a/net/ipv6/ip6mr.c b/net/ipv6/ip6mr.c index 1479618..3e2d964 100644 --- a/net/ipv6/ip6mr.c +++ b/net/ipv6/ip6mr.c @@ -603,6 +603,7 @@ static int mif6_add(struct mif6ctl *vifc, int mrtsock) int vifi = vifc->mif6c_mifi; struct mif_device *v = &vif6_table[vifi]; struct net_device *dev; + int err; /* Is vif busy ? */ if (MIF_EXISTS(vifi)) @@ -632,7 +633,9 @@ static int mif6_add(struct mif6ctl *vifc, int mrtsock) return -EINVAL; } - dev_set_allmulti(dev, 1); + err = dev_set_allmulti(dev, 1); + if (err) + return err; /* * Fill in the VIF structures -- 1.5.3.4 -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists