netdev - Re: [PATCH] fs_enet: restore promiscuous and multicast settings in restart()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8496f91a0806200155hcb1f440ld7b5f678d95fdb85@mail.gmail.com>
Date:	Fri, 20 Jun 2008 12:55:22 +0400
From:	"Matvejchikov Ilya" <matvejchikov@...il.com>
To:	"Laurent Pinchart" <laurentp@...-semaphore.com>
Cc:	"Bill Fink" <billfink@...dspring.com>, linuxppc-dev@...abs.org,
	netdev@...r.kernel.org, pantelis.antoniou@...il.com,
	vbordug@...mvista.com
Subject: Re: [PATCH] fs_enet: restore promiscuous and multicast settings in restart()

>> > diff --git a/drivers/net/fs_enet/mac-fcc.c b/drivers/net/fs_enet/mac-fcc.c
>> > index ce40cf9..1a95cf1 100644
>> > --- a/drivers/net/fs_enet/mac-fcc.c
>> > +++ b/drivers/net/fs_enet/mac-fcc.c
>> > @@ -464,6 +464,9 @@ static void restart(struct net_device *dev)
>> >             C32(fccp, fcc_fpsmr, FCC_PSMR_FDE | FCC_PSMR_LPB);
>> >
>> >     S32(fccp, fcc_gfmr, FCC_GFMR_ENR | FCC_GFMR_ENT);
>> > +
>> > +   /* Restore multicast and promiscous settings */
>> > +   set_multicast_list(dev);
>> >  }

Is it right to call set_multicast_list() after turning on transmitter
and receiver? May be swap this lines around?
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html