lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Fri, 20 Jun 2008 13:09:35 +0300
From:	Octavian Purdila <>
To:	Jarek Poplawski <>
Subject: Re: [RESEND] [PATCH] tcp: fix for splice receive when used with software LRO

On Friday 20 June 2008, Jarek Poplawski wrote:

> This patch looks fine to me, but I wonder if, btw., this place can't
> be optimized a bit, so why can't we simply:
> 	if (spd_fill_page(spd, f->page, plen, poff, skb))
> 		goto err;
> in both cases, since nothing more can't be filled after this?

Yes, you are right. Here is the patch with your suggestions in place, tested. 

BTW, I have another trivial fix and a RFC related to tcp splice read that I've 
sent a while ago. Should I resend them as well? 


View attachment "x" of type "text/plain" (2250 bytes)

Powered by blists - more mailing lists