netdev - Re: [RESEND] [PATCH] tcp: fix for splice receive when used with software LRO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080620130129.GA4417@ff.dom.local>
Date:	Fri, 20 Jun 2008 13:01:29 +0000
From:	Jarek Poplawski <jarkao2@...il.com>
To:	Octavian Purdila <opurdila@...acom.com>
Cc:	netdev@...r.kernel.org
Subject: Re: [RESEND] [PATCH] tcp: fix for splice receive when used with
	software LRO

On Fri, Jun 20, 2008 at 03:39:24PM +0300, Octavian Purdila wrote:
> On Friday 20 June 2008, Jarek Poplawski wrote:
> 
> > If so, can't we make it all simpler now, without this new "error"
> > variable, and simply skipping this: "if (spd->nr_pages - nr_pages)"
> > test under "done:", so, doing this block unconditional or maybe (I
> > didn't check this enough) changing this test a little to catch there
> > this offset update for frag_list?
> 
> Let me try to wrap my brain around this again :) and see if we don't miss 
> anything. In the process, maybe I can even find a way to make this code 
> easier to understand.
> 

Sure, no need to hurry, and after all, I'm OK with the current patch too.

Jarek P.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html